12 add translations #258
Merged
12 add translations #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mhhd2020
added
documentation
… code loaded as module
mhhd2020
force-pushed
the
12-add-translations
branch
from
901c7df to
8339ebf
Compare
…etch-map-tool into 12-add-translations
Dockerfile
Outdated
| @@ -39,6 +39,9 @@ COPY --chown=smt:smt sketch_map_tool sketch_map_tool | |||
| COPY --chown=smt:smt data/ data/ | |||
| RUN python -m poetry install --no-ansi --no-interaction | |||
|
|
|||
| # Compile translations | |||
| RUN python3 -m poetry run pybabel compile -d sketch_map_tool/translations | |||
There was a problem hiding this comment.
Suggested change
| RUN python3 -m poetry run pybabel compile -d sketch_map_tool/translations | |
| RUN python -m poetry run pybabel compile -d sketch_map_tool/translations |
docs/development-setup.md
Outdated
| @@ -61,7 +61,7 @@ celery --app sketch_map_tool.tasks worker --loglevel=INFO | |||
|
|
|||
| ```bash | |||
| mamba activate smt | |||
| flask --app sketch_map_tool/routes.py --debug run | |||
| flask --app sketch_map_tool/routes.py --debug run -p 5000 | |||
There was a problem hiding this comment.
Suggested change
| flask --app sketch_map_tool/routes.py --debug run -p 5000 | |
| flask --app sketch_map_tool/routes.py --debug run |
pyproject.toml
Outdated
Comment on lines
24
to
27
| # these dependencies are maintained by your local setup and have to be fixed for now, since poetry and (py)gdal packages can't work together | ||
| # if you change these versions, please change them in development-setup.md, Dockerfile and .github/workflows/python.yml as well | ||
| #numpy = "1.23.5" | ||
| #pygdal = "3.4.1.10" |
There was a problem hiding this comment.
Suggested change
| # these dependencies are maintained by your local setup and have to be fixed for now, since poetry and (py)gdal packages can't work together | |
| # if you change these versions, please change them in development-setup.md, Dockerfile and .github/workflows/python.yml as well | |
| #numpy = "1.23.5" | |
| #pygdal = "3.4.1.10" |
sketch_map_tool/__init__.py
Outdated
| @@ -1,8 +1,10 @@ | |||
| import logging | |||
| import os | |||
esbuild.js
Outdated
| @@ -16,7 +17,7 @@ require("esbuild") | |||
| entryNames: "[dir]", // will name the result files by their folder names | |||
| outbase: "./client-src", | |||
| bundle: true, | |||
| minify: true, | |||
| // minify: true, | |||
sketch_map_tool/__init__.py
Outdated
| flask_app.config.update( | ||
| CELERY_CONFIG=CELERY_CONFIG, | ||
| BABEL_DEFAULT_LOCALE="en", | ||
| LANGUAGES={"en": "English", "de": "Deutsch", "pt": "Portuguese"}, |
There was a problem hiding this comment.
Suggested change
| LANGUAGES={"en": "English", "de": "Deutsch", "pt": "Portuguese"}, | |
| LANGUAGES={"en": "English", "de": "Deutsch"}, |
…etch-map-tool into 12-add-translations
👍 Nice to see that the Sketch Map Tool is still flourishing and continues to be improved! |
Great to hear from you. Yeah, the Sketch Map Tool is in active development :) |
matthiasschaub
previously approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdCloses #367