-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for integral finite elements #280
Conversation
Mention in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions left from my side (beside the comments).
- H(div) and H(curl) elements can be interpreted as integral elements. I assume they still crash on this branch. Can we add meaningful error messages for these?
- Can add some comment on the local projection (in the code)? For me it is not really obvious why this is the correct way to handle the visualization.
Furthermore, is there some way to add a simple regression test on this?
H(div) and H(curl) are vector finite elements, so they are visualized as vector fields by a completely different object. Unfortunately, GLVis does not have smooth (i.e. interpolated normals) visualization of any vector fields, as I mentioned in #284 .
I added a little comment, but it is really simple. The point value of integral elements is the DOF value divided by the Jacobian, see
Regression testing is poor in GLVis, it only checks against saved streams from runs of example codes. It does not cover a great fraction of the options. I have proposed to improve it, but it does not have a priority (but if you want to take it, go for it 😉). Anyway, it is a different repo, so it even cannot be added here, and also we do not have examples with integral elements, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for elaborating @najlkin and also thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this, @najlkin!
This PR adds support for integral finite elements, which were loaded, but crashed GLVis 💣 .
Status:
Vector grid functions in 2D(No smooth visualization of vector fields in 2D 😞 )Vector grid functions in 3D(No smooth visualization with value-based displacement 😞 )