-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number formatting #288
Merged
Merged
Number formatting #288
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
e3a5704
implement general NumberFormat() function
justinlaughlin 76eb7a7
add option to show sign (showpos)
justinlaughlin 1573db5
begin implementing F2 to change number format
justinlaughlin b1bd9d1
remove h option
justinlaughlin 359cc45
swap order of args in NumberFormat()
justinlaughlin 30b5f81
add prompt() function and also reverting F2 changes
justinlaughlin 458114a
seems to be working
justinlaughlin 8cb2e0f
added ability to specify a default using prompt()
justinlaughlin 9f881b4
add printf style option to FormatNumber
justinlaughlin 92687d9
make number formatter lazy so its easier to pass around
justinlaughlin 73b4bb6
change vsdata to use updated NumberFormatter
justinlaughlin 84cdf08
forgot semicolon
justinlaughlin 00cd71d
fix few more bugs
justinlaughlin dd9c4d4
add default formatter
justinlaughlin 039c978
stream is working for axis number format
justinlaughlin 23d49ca
stream is working for axis and colorbar now
justinlaughlin fc96c64
add in hooks to glvis script
justinlaughlin f1e28f5
update readme and HelpStrings
justinlaughlin b3d4d16
add reminder to press <space> to trigger script steps :)
justinlaughlin f91f3e4
added sanitization check on snprintf format string
justinlaughlin a2f809d
added missing apostrophes
justinlaughlin 9a3b909
update changelog
justinlaughlin f31f481
Merge branch 'master' into number-formatting
justinlaughlin b8479b0
updated test/data
tzanio 3d8f761
update regex
justinlaughlin 8b5af59
minor
tzanio 3686dd0
Merged in master, conflict in CHANGELOG
tzanio abc6f59
Styling
tzanio 8d4b682
conform to style and add message to prompt()
justinlaughlin 72d38fb
Reworked and simplified a bit the handling of the key events in the
v-dobrev da9d2bc
Fix SdlWindow::signalKeyDown for the updated key events handling.
v-dobrev ed6db97
Merge pull request #294 from GLVis/number-formatting-keys-fix
justinlaughlin d1920e3
Testing new baseline.
v-dobrev f50907d
update data submodule to master
justinlaughlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
Alt
mean on Mac? Is itoption
orcommand
-- it will be good to clarify it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what's it worth, we do use Alt already in https://github.com/glvis/glvis/?tab=readme-ov-file#advanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to test but I did see other places that used Alt like Tzanio mentioned. It'd probably be good to mention it somewhere at the top.