Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue when numlock is on #300

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix an issue when numlock is on #300

merged 1 commit into from
Jul 26, 2024

Conversation

v-dobrev
Copy link
Member

When handling key-down events, do not let the state of keys like numlock influence the logic.

Currently, if numlock is on, keys like P and O are precessed in keyDownEvent whereas the intent is for them to be proceesed in textInputEvent.

Reported-by: @najlkin

@v-dobrev v-dobrev added the bug label Jul 26, 2024
@v-dobrev v-dobrev self-assigned this Jul 26, 2024
@najlkin najlkin mentioned this pull request Jul 26, 2024
Merged
22 tasks
tzanio
tzanio approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this works for me too, thanks @v-dobrev !

@tzanio tzanio merged commit ae4abfe into master Jul 26, 2024
10 checks passed
@tzanio tzanio deleted the numlock-fix branch July 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlaughlin justinlaughlin justinlaughlin approved these changes

@najlkin najlkin najlkin approved these changes

@tzanio tzanio tzanio approved these changes

Assignees

@v-dobrev v-dobrev

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-dobrev @tzanio @najlkin @justinlaughlin