-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Alt handling to allow layout translation #316
base: master
Are you sure you want to change the base?
Conversation
This doesn't seem to work on Mac -- I tested e.g. |
Left or right Alt? ... if they are on Mac 😅 |
Either left or right |
Hmm, that matches, I have found online that there are special symbols mapped to keys on Mac without making a difference between left and right |
Ok, this is a more elegant solution and also works for Windows or Linux users who do not know the difference between left and right Alt 😁 . It stores the physical key from |
Maybe I am doing something wrong, but this also doesn't work on a Mac: "option+c" acts like "shift+c" and similarly for "option+a" |
Ahh, I stored the physical key, which is always capital 😅 . Now it must work, otherwise... 🤪 |
Ok, it seems to work with 031ca5c |
I'm testing this with a native Windows build with MSVC and both |
Just tested on Mac and can confirm that |
Hmm, that |
If it does not work with neither of them, we may let pass only right Alt to the text input event, because only that one does the translation anyway, so at least the left Alt will work on Windows 🤔 . |
Ok, so I basically reverted that to handle |
Btw, is |
Neither the left nor the right |
Fixed Alt handling to allow key translation for different layouts by passing modifiers to the text input event.
👉 Please test on different platforms. On Windows+WSL or Linux: Left Alt does not translate the key and Right Alt (AltGr) does translate the key.
❓ This is a possible fix for #311 .