Reports improvements #1862
Merged
Reports improvements #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* show annotators record in each userGroup owned/managed by the instructor * For each userGroup, list group members and show their annotation records on each organisms that the userGroup has permission on
…nnotator * modified instructor report, group annotators with userGroups, show organism breakdown as the same way to the annotator report
…ileformats: csv, excel, pdf, ods, rtf, xml
…roups (id or name) or export all qualified userGroups
* add dropdown menu to select a userGroup for instructor report
ghost
assigned 
nathandunn
reviewed
Feb 21, 2018
| @@ -504,4 +547,94 @@ class AnnotatorController { | |||
| redirect(uri: "/auth/login") | |||
| } | |||
| } | |||
|
|
|||
| def export() { | |||
| if(!params.max) params.max = 10 | |||
There was a problem hiding this comment.
would do: params.max = params.max ?: 10
Will do the same thing roughly.
|
@Yating-L These changes look great (I had only one minor suggestion). I'll test it today or tomorrow to get it merged in properly. |
|
Tested and looks great. Thanks for all of the improvements. |
|
Thank you for reviewing the request! @nathandunn |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a couple of things to improve the reports for admins/instructors