Use fmin and fmax for partial instead of 3' and 5' #2646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an email from a user, they stated:
From what I can tell, the "partial" feature in Apollo is based on a similar feature in Artemis, see here. Artemis appears to use 5' and 3' relative to the feature on the strand, though, and Apollo does not, so I think all the above observations are correct.
After discussion with the user, we decided to change the checkboxes in the UI to say "fmin" and "fmax" instead of 3' and 5'. This accurately describes how Apollo handles the data internally, and is not ambiguous.
Before:
After: