-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add configuration options for visibility of track's graphical and tab…
…le views (#461) * config options for track graphical and table views * enable both graphical and table by default * Remove unused config from LinearApolloDisplay * Move table/graphical options to submenu * Fix tests --------- Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>
- Loading branch information
1 parent
1daadfa
commit b8a4e94
Showing
8 changed files
with
177 additions
and
103 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 5 additions & 14 deletions
19
packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/configSchema.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,7 @@ | ||
import { ConfigurationSchema } from '@jbrowse/core/configuration' | ||
import PluginManager from '@jbrowse/core/PluginManager' | ||
import type LinearGenomeViewPlugin from '@jbrowse/plugin-linear-genome-view' | ||
|
||
export function configSchemaFactory(pluginManager: PluginManager) { | ||
const LGVPlugin = pluginManager.getPlugin( | ||
'LinearGenomeViewPlugin', | ||
) as LinearGenomeViewPlugin | ||
const { baseLinearDisplayConfigSchema } = LGVPlugin.exports | ||
|
||
return ConfigurationSchema( | ||
'LinearApolloDisplay', | ||
{ height: { type: 'number', defaultValue: 500 } }, | ||
{ baseConfiguration: baseLinearDisplayConfigSchema, explicitlyTyped: true }, | ||
) | ||
} | ||
export const configSchema = ConfigurationSchema( | ||
'LinearApolloDisplay', | ||
{}, | ||
{ explicitIdentifier: 'displayId', explicitlyTyped: true }, | ||
) |
2 changes: 1 addition & 1 deletion
2
packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
export { configSchemaFactory } from './configSchema' | ||
export { configSchema } from './configSchema' | ||
export { stateModelFactory } from './stateModel' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 0 additions & 43 deletions
43
packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/stateModel/trackHeightMixin.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.