Apollo CLI #331
Assignees
Comments
dariober
added a commit
that referenced
this issue
Nov 30, 2023
garrettjstevens
pushed a commit
that referenced
this issue
Dec 12, 2023
garrettjstevens
added a commit
that referenced
this issue
Feb 13, 2024
* Remove clientId from plugin * Consolidate to one login endpoint * Fix menu items not appearing * Stub for apollo login (issue #330 and #331) * A few mostly automatic fixes * Temporary commit with stubs for login using name and password * Start implementing login with username and password * Root login should work but needs tidying up for errors * Misc cleanups * Fix loading of commands * Get one test working * Get tests working even with imported files * Add coverage to CLI tests * Don't lint bin/ files * Draft for apollo config cli * Refactor to allow multiple profiles * Add some validation and update tests * Update oclif so we can use flagSortOrder * Make login subcommand aware of profiles * Add missing file * Refactor Profile to have address and accessType not null * Misc. cleanup * Address [checklist](#354 (review)) This commit should address most of the items in #354 (review) There are tests for most of them. `"default.rootCredentials.password" must be a string` occurs if an entry is expected to be string and instead is a number without quotes. The cli quotes as appropriate. > Make sure all commands print a sensible error message if the config file is > not valid YAML or doesn't pass validation Currently, the cli fails with a fairly friendly message if the yaml is malformed, but if it is valid, it will process it anyway * Lint and formatting fixes * Make sure tests work if config dir doesn't exist yet * Disable one test until server can be mocked --------- Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>
|
Done in #354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Create an Apollo CLI using oclif. The first command will be
apollo login(see #330).For reference, the JBrowse CLI is here: https://github.com/GMOD/jbrowse-components/tree/main/products/jbrowse-cli
The text was updated successfully, but these errors were encountered: