Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature import conversion tests #441

Merged
merged 8 commits into from
Sep 21, 2024
Merged

Add feature import conversion tests #441

merged 8 commits into from
Sep 21, 2024

Commits on Sep 20, 2024

  1. Temp commit

    @dariober @garrettjstevens
    dariober authored and garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dde4381 View commit details
    Browse the repository at this point in the history

  2. Use chai to deeply compare annotation features

    @garrettjstevens
    garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6a4290c View commit details
    Browse the repository at this point in the history

  3. Some working tests

    @dariober @garrettjstevens
    dariober authored and garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8230927 View commit details
    Browse the repository at this point in the history

  4. Fix import

    @dariober @garrettjstevens
    dariober authored and garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7da9f89 View commit details
    Browse the repository at this point in the history

  5. Tests for feature conversion (#429) 

    Test `Convert example 3` fails because there should be 4 CDSs in the
converted feature object but current code detects 3

Test `Convert braker gff` fails because the converted feature includes
intron, start_codon, and stop_codon
    @dariober @garrettjstevens
    dariober authored and garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    58e456c View commit details
    Browse the repository at this point in the history

  6. Fix linter

    @dariober @garrettjstevens
    dariober authored and garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    07945da View commit details
    Browse the repository at this point in the history

  7. Fix CDS overlap calculation

    @garrettjstevens
    garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3d39e44 View commit details
    Browse the repository at this point in the history

  8. Ignore more calculated properties on conversion

    @garrettjstevens
    garrettjstevens committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d81c5e7 View commit details
    Browse the repository at this point in the history