Fix lint warnings

packages/circular-view/src/CircularView/models/viewportVisibleRegion.js

@@ -177,7 +177,7 @@ export function viewportVisibleSection(viewSides, circleCenter, circleRadius) {
     vertices.push([0, viewB])
   }
 
-  const verticesOriginal = vertices.map(([x, y]) => [x + cx, y + cy])
+  // const verticesOriginal = vertices.map(([x, y]) => [x + cx, y + cy])
 
   // now convert them all to polar and take the max and min of rho and theta
 

packages/circular-view/src/CircularView/models/viewportVisibleRegion.test.js

@@ -94,7 +94,7 @@ describe('viewportVisibleSection', () => {
   test('viewport on upper center 2', () => {
     // [180.48708681644143, 359.3411680673888] [4.6042679453532855, 541.6042679453533]
     // see '~/Desktop/Screen Shot 2019-06-28 at 3.01.22 PM.png'
-    const { theta, rho } = viewportVisibleSection(
+    const { theta } = viewportVisibleSection(
       [0, 962, 157, 557],
       [561.6042679453533, 561.6042679453533],
       541.6042679453533,

packages/circular-view/src/StructuralVariantChordRenderer/reactComponent.js

@@ -1,8 +1,12 @@
 export default ({ jbrequire }) => {
   const React = jbrequire('react')
-  const { observer } = jbrequire('mobx-react')
+  const { observer, PropTypes: MobxPropTypes } = jbrequire('mobx-react')
   const { polarToCartesian } = jbrequire('@gmod/jbrowse-core/util')
   const { readConfObject } = jbrequire('@gmod/jbrowse-core/configuration')
+  const { PropTypes: CommonPropTypes } = jbrequire(
+    '@gmod/jbrowse-core/mst-types',
+  )
+  const PropTypes = jbrequire('prop-types')
 
   function bpToRadians(block, pos) {
     const blockStart = block.region.elided ? 0 : block.region.start
@@ -94,5 +98,19 @@ export default ({ jbrequire }) => {
     return <>{chords}</>
   }
 
+  StructuralVariantChords.propTypes = {
+    features: PropTypes.instanceOf(Map).isRequired,
+    config: CommonPropTypes.ConfigSchema.isRequired,
+    trackModel: MobxPropTypes.objectOrObservableObject,
+    blockDefinitions: PropTypes.arrayOf(MobxPropTypes.objectOrObservableObject)
+      .isRequired,
+    radius: PropTypes.number.isRequired,
+    bezierRadius: PropTypes.number.isRequired,
+  }
+
+  StructuralVariantChords.defaultProps = {
+    trackModel: undefined,
+  }
+
   return observer(StructuralVariantChords)
 }

packages/circular-view/src/StructuralVariantChordTrack/components/RpcRenderedSvgGroup.js

@@ -3,10 +3,11 @@ export default ({ jbrequire }) => {
   const { isAlive } = jbrequire('mobx-state-tree')
   const { useEffect, useRef } = React
   const { observer } = jbrequire('mobx-react-lite')
+  const { PropTypes: MobxPropTypes } = jbrequire('mobx-react')
   const { unmountComponentAtNode, hydrate } = jbrequire('react-dom')
 
   function RpcRenderedSvgGroup({ model }) {
-    const { id, data, html, filled, renderProps, renderingComponent } = model
+    const { data, html, filled, renderProps, renderingComponent } = model
 
     const ssrContainerNode = useRef(null)
 
@@ -46,5 +47,9 @@ export default ({ jbrequire }) => {
     return <g ref={ssrContainerNode} />
   }
 
+  RpcRenderedSvgGroup.propTypes = {
+    model: MobxPropTypes.observableObject.isRequired,
+  }
+
   return observer(RpcRenderedSvgGroup)
 }

packages/circular-view/src/StructuralVariantChordTrack/components/index.js

@@ -1,17 +1,20 @@
 export default ({ jbrequire }) => {
   const React = jbrequire('react')
-  const { observer } = jbrequire('mobx-react')
+  const { observer, PropTypes: MobxPropTypes } = jbrequire('mobx-react')
 
   const Loading = jbrequire(require('../../ChordTrack/components/Loading'))
   const TrackError = jbrequire(
     require('../../ChordTrack/components/TrackError'),
   )
   const RpcRenderedSvgGroup = jbrequire(require('./RpcRenderedSvgGroup'))
 
-  function StructuralVariantChordTrack({ track, view }) {
+  function StructuralVariantChordTrack({ track }) {
     if (track.error) return <TrackError model={track} />
     if (!track.filled) return <Loading model={track} />
     return <RpcRenderedSvgGroup model={track} />
   }
+  StructuralVariantChordTrack.propTypes = {
+    track: MobxPropTypes.observableObject.isRequired,
+  }
   return observer(StructuralVariantChordTrack)
 }

packages/circular-view/src/StructuralVariantChordTrack/models/index.js

@@ -1,8 +1,7 @@
 export default pluginManager => {
   const { jbrequire } = pluginManager
-  const { reaction } = jbrequire('mobx')
 
-  const { types, addDisposer } = jbrequire('mobx-state-tree')
+  const { types } = jbrequire('mobx-state-tree')
   const { ConfigurationSchema, ConfigurationReference } = jbrequire(
     '@gmod/jbrowse-core/configuration',
   )

packages/core/BaseAdapter.ts

@@ -1,5 +1,5 @@
 import { Observer, Observable, merge } from 'rxjs'
-import { tap, takeUntil } from 'rxjs/operators'
+import { takeUntil } from 'rxjs/operators'
 import { IRegion as Region } from './mst-types'
 import { ObservableCreate } from './util/rxjs'
 import { checkAbortSignal, observeAbortSignal } from './util'

packages/core/components/ResizeHandleHorizontal.js

@@ -15,6 +15,7 @@ const styles = {
 class ResizeHandleHorizontal extends Component {
   static propTypes = {
     classes: ReactPropTypes.objectOf(ReactPropTypes.string).isRequired,
+    style: ReactPropTypes.shape().isRequired,
     objectId: ReactPropTypes.string.isRequired,
     onVerticalDrag: ReactPropTypes.func.isRequired,
   }

packages/core/pluggableElementTypes/renderers/ServerSideRendererType.js

@@ -1,6 +1,5 @@
 import { renderToString } from 'react-dom/server'
 import { filter, ignoreElements, tap } from 'rxjs/operators'
-import { getSnapshot } from 'mobx-state-tree'
 import { readConfObject } from '../../configuration'
 import { checkAbortSignal, iterMap } from '../../util'
 import SimpleFeature from '../../util/simpleFeature'

packages/core/rpc/RpcManager.js

@@ -1,4 +1,3 @@
-import { decorate, observable } from 'mobx'
 import { getSnapshot, isStateTreeNode, isAlive } from 'mobx-state-tree'
 import { readConfObject } from '../configuration'
 

packages/core/util/index.ts

@@ -6,7 +6,6 @@ import fromEntries from 'object.fromentries'
 import { useEffect, useState } from 'react'
 import { Feature } from './simpleFeature'
 import { IRegion, INoAssemblyRegion } from '../mst-types'
-import { ObservableCreate } from './rxjs'
 
 // @ts-ignore
 if (!Object.fromEntries) {

packages/jbrowse-web/src/rpc.worker.js

@@ -22,11 +22,11 @@ const logBuffer = []
 function flushLog() {
   if (logBuffer.length) {
     for (const l of logBuffer) {
-      // eslint-disable-next-line no-console
       const [head, ...rest] = l
       if (head === 'rpc-error') {
         console.error(head, ...rest)
       } else {
+        // eslint-disable-next-line no-console
         console.log(head, ...rest)
       }
     }

packages/linear-genome-view/src/BasicTrack/util/serverSideRenderedBlock.js

@@ -1,7 +1,7 @@
 import { types, getParent, isAlive, addDisposer } from 'mobx-state-tree'
 
 import { reaction } from 'mobx'
-import { getConf, readConfObject } from '@gmod/jbrowse-core/configuration'
+import { getConf } from '@gmod/jbrowse-core/configuration'
 
 import { Region } from '@gmod/jbrowse-core/mst-types'