Fix bug where multi-quantitative tracks plotted incorrectly for some …

…bigwigs with empty regions (#3839)
GMOD · Aug 9, 2023 · 6f1fa62 · 6f1fa62
1 parent 1c43657
commit 6f1fa62
Show file tree

Hide file tree

Showing 9 changed files with 476 additions and 462 deletions.
diff --git a/.../src/ConfigurationEditorWidget/components/__snapshots__/ConfigurationEditor.test.tsx.snap b/.../src/ConfigurationEditorWidget/components/__snapshots__/ConfigurationEditor.test.tsx.snap
@@ -814,7 +814,7 @@ exports[`ConfigurationEditor widget renders all the different types of built-in
                     class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementEnd css-j204z7-MuiFormControlLabel-root"
                   >
                     <span
-                      class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-12wnr2w-MuiButtonBase-root-MuiCheckbox-root"
+                      class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary css-12wnr2w-MuiButtonBase-root-MuiCheckbox-root"
                     >
                       <input
                         checked=""
@@ -1803,7 +1803,7 @@ exports[`ConfigurationEditor widget renders with defaults of the PileupTrack sch
                                   class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementEnd css-j204z7-MuiFormControlLabel-root"
                                 >
                                   <span
-                                    class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-12wnr2w-MuiButtonBase-root-MuiCheckbox-root"
+                                    class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-root MuiCheckbox-colorPrimary css-12wnr2w-MuiButtonBase-root-MuiCheckbox-root"
                                   >
                                     <input
                                       class="PrivateSwitchBase-input css-1m9pwf3"
@@ -1910,7 +1910,7 @@ exports[`ConfigurationEditor widget renders with defaults of the PileupTrack sch
                                   class="MuiFormControlLabel-root MuiFormControlLabel-labelPlacementEnd css-j204z7-MuiFormControlLabel-root"
                                 >
                                   <span
-                                    class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-12wnr2w-MuiButtonBase-root-MuiCheckbox-root"
+                                    class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-root MuiCheckbox-colorPrimary css-12wnr2w-MuiButtonBase-root-MuiCheckbox-root"
                                   >
                                     <input
                                       class="PrivateSwitchBase-input css-1m9pwf3"

diff --git a/...hicalTrackSelectorWidget/components/__snapshots__/HierarchicalTrackSelector.test.tsx.snap b/...hicalTrackSelectorWidget/components/__snapshots__/HierarchicalTrackSelector.test.tsx.snap
@@ -338,7 +338,7 @@ exports[`renders with a couple of categorized tracks 1`] = `
               data-mui-internal-clone-element="true"
             >
               <span
-                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
+                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-root MuiCheckbox-colorPrimary css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
               >
                 <input
                   class="PrivateSwitchBase-input css-1m9pwf3"
@@ -477,7 +477,7 @@ exports[`renders with a couple of categorized tracks 1`] = `
               data-mui-internal-clone-element="true"
             >
               <span
-                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
+                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
               >
                 <input
                   checked=""
@@ -625,7 +625,7 @@ exports[`renders with a couple of categorized tracks 1`] = `
               data-mui-internal-clone-element="true"
             >
               <span
-                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
+                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
               >
                 <input
                   checked=""
@@ -876,7 +876,7 @@ exports[`renders with a couple of uncategorized tracks 1`] = `
               data-mui-internal-clone-element="true"
             >
               <span
-                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
+                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-root MuiCheckbox-colorPrimary css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
               >
                 <input
                   class="PrivateSwitchBase-input css-1m9pwf3"
@@ -953,7 +953,7 @@ exports[`renders with a couple of uncategorized tracks 1`] = `
               data-mui-internal-clone-element="true"
             >
               <span
-                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
+                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
               >
                 <input
                   checked=""
@@ -1031,7 +1031,7 @@ exports[`renders with a couple of uncategorized tracks 1`] = `
               data-mui-internal-clone-element="true"
             >
               <span
-                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeMedium css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
+                class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary Mui-checked MuiCheckbox-root MuiCheckbox-colorPrimary css-5qvvf1-MuiButtonBase-root-MuiCheckbox-root-compactCheckbox"
               >
                 <input
                   checked=""

diff --git a/...management/src/PluginStoreWidget/components/__snapshots__/PluginStoreWidget.test.tsx.snap b/...management/src/PluginStoreWidget/components/__snapshots__/PluginStoreWidget.test.tsx.snap
@@ -785,7 +785,7 @@ exports[`renders with the available plugins 1`] = `
                     class="MuiTypography-root MuiTypography-h5 css-1ldbtdh-MuiTypography-root"
                   >
                     <a
-                      class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-6z5vhu-MuiTypography-root-MuiLink-root"
+                      class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-ygjubp-MuiTypography-root-MuiLink-root"
                       href="https://github.com/GMOD/jbrowse-plugin-msaview#readme"
                       rel="noopener"
                       target="_blank"

diff --git a/plugins/menus/src/AboutWidget/components/__snapshots__/AboutWidget.test.tsx.snap b/plugins/menus/src/AboutWidget/components/__snapshots__/AboutWidget.test.tsx.snap
@@ -18,7 +18,7 @@ exports[`<AboutWidget /> renders 1`] = `
     JBrowse is a
      
     <a
-      class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1xylxj1-MuiTypography-root-MuiLink-root"
+      class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1bhi0za-MuiTypography-root-MuiLink-root"
       href="http://gmod.org/"
       rel="noopener noreferrer"
       target="_blank"
@@ -45,7 +45,7 @@ exports[`<AboutWidget /> renders 1`] = `
     <ul>
       <li>
         <a
-          class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1xylxj1-MuiTypography-root-MuiLink-root"
+          class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1bhi0za-MuiTypography-root-MuiLink-root"
           href="http://google.com"
           rel="noopener noreferrer"
           target="_blank"

diff --git a/plugins/menus/src/HelpWidget/components/__snapshots__/HelpWidget.test.js.snap b/plugins/menus/src/HelpWidget/components/__snapshots__/HelpWidget.test.js.snap
@@ -20,7 +20,7 @@ exports[`<HelpWidget /> renders 1`] = `
   <ul>
     <li>
       <a
-        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1xylxj1-MuiTypography-root-MuiLink-root"
+        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1bhi0za-MuiTypography-root-MuiLink-root"
         href="https://github.com/GMOD/jbrowse-components/discussions"
         rel="noopener noreferrer"
         target="_blank"
@@ -30,7 +30,7 @@ exports[`<HelpWidget /> renders 1`] = `
     </li>
     <li>
       <a
-        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1xylxj1-MuiTypography-root-MuiLink-root"
+        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1bhi0za-MuiTypography-root-MuiLink-root"
         href="https://github.com/GMOD/jbrowse-components/issues/new/choose"
         rel="noopener noreferrer"
         target="_blank"
@@ -40,7 +40,7 @@ exports[`<HelpWidget /> renders 1`] = `
     </li>
     <li>
       <a
-        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1xylxj1-MuiTypography-root-MuiLink-root"
+        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1bhi0za-MuiTypography-root-MuiLink-root"
         href="https://jbrowse.org/jb2/docs/user_guide"
         rel="noopener noreferrer"
         target="_blank"
@@ -50,7 +50,7 @@ exports[`<HelpWidget /> renders 1`] = `
     </li>
     <li>
       <a
-        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1xylxj1-MuiTypography-root-MuiLink-root"
+        class="MuiTypography-root MuiTypography-inherit MuiLink-root MuiLink-underlineAlways css-1bhi0za-MuiTypography-root-MuiLink-root"
         href="https://jbrowse.org/jb2/docs/"
         rel="noopener noreferrer"
         target="_blank"

diff --git a/plugins/wiggle/src/MultiDensityRenderer/MultiDensityRenderer.ts b/plugins/wiggle/src/MultiDensityRenderer/MultiDensityRenderer.ts
@@ -10,7 +10,7 @@ export default class MultiXYPlotRenderer extends WiggleBaseRenderer {
     const { bpPerPx, sources, regions, features } = props
     const [region] = regions
     const groups = groupBy([...features.values()], f => f.get('source'))
-    const height = props.height / Object.keys(groups).length
+    const height = props.height / sources.length
     const width = (region.end - region.start) / bpPerPx
     let feats = [] as Feature[]
     ctx.save()

diff --git a/plugins/wiggle/src/MultiRowLineRenderer/MultiRowLineRenderer.ts b/plugins/wiggle/src/MultiRowLineRenderer/MultiRowLineRenderer.ts
@@ -10,7 +10,7 @@ export default class MultiRowLineRenderer extends WiggleBaseRenderer {
     const { bpPerPx, sources, regions, features } = props
     const [region] = regions
     const groups = groupBy([...features.values()], f => f.get('source'))
-    const height = props.height / Object.keys(groups).length
+    const height = props.height / sources.length
     const width = (region.end - region.start) / bpPerPx
     let feats = [] as Feature[]
     ctx.save()

diff --git a/plugins/wiggle/src/MultiRowXYPlotRenderer/MultiRowXYPlotRenderer.ts b/plugins/wiggle/src/MultiRowXYPlotRenderer/MultiRowXYPlotRenderer.ts
@@ -11,7 +11,7 @@ export default class MultiXYPlotRenderer extends WiggleBaseRenderer {
     const { bpPerPx, sources, regions, features } = props
     const [region] = regions
     const groups = groupBy([...features.values()], f => f.get('source'))
-    const height = props.height / Object.keys(groups).length
+    const height = props.height / sources.length
     const width = (region.end - region.start) / bpPerPx
     const Color = await import('color').then(f => f.default)
     let feats = [] as Feature[]