Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub menus can go off screen with LGV MiniControls #3690

Closed
cmdcolin opened this issue May 8, 2023 · 3 comments · Fixed by #3731
Closed

Sub menus can go off screen with LGV MiniControls #3690

cmdcolin opened this issue May 8, 2023 · 3 comments · Fixed by #3731
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

cmdcolin commented May 8, 2023

image
@cmdcolin cmdcolin added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 8, 2023
@carolinebridge
Copy link
Contributor

semi-related, this happens at the bottom of the screen too (i.e. non-mini controls sub menus are vertically cut off)

image

@cmdcolin
Copy link
Collaborator Author

@carolinebridge-oicr we may be able to fix that by converting the view menu from a @jbrowse/core/ui/Menu to @jbrowse/core/ui/CascadingMenu

@cmdcolin
Copy link
Collaborator Author

not sure if that would fix both issues or just that one...

@cmdcolin cmdcolin mentioned this issue May 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix view menu going off screen in some cases GMOD/jbrowse-components
2 participants
@cmdcolin @carolinebridge