Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view menu going off screen in some cases #3731

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

This changes the code to use a "CascadingMenu" for the viewMenu

It creates a "CascadingMenuButton" component that allows easier usage of the CascadingMenu concept (triggered on a button click)

Fixes #3690

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 29, 2023
@cmdcolin cmdcolin force-pushed the cascading_menu_viewmenu branch from 573bac9 to 4a7d87c Compare May 29, 2023 19:54
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 29, 2023
@cmdcolin cmdcolin force-pushed the cascading_menu_viewmenu branch 2 times, most recently from 0e6dd30 to a5d850f Compare May 29, 2023 21:00
@cmdcolin cmdcolin requested a review from carolinebridge May 29, 2023 21:12
@cmdcolin cmdcolin force-pushed the cascading_menu_viewmenu branch from a5d850f to 76baec5 Compare May 29, 2023 21:19
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #3731 (76baec5) into main (527b08e) will increase coverage by 0.03%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #3731      +/-   ##
==========================================
+ Coverage   64.37%   64.40%   +0.03%     
==========================================
  Files         962      963       +1     
  Lines       29958    29945      -13     
  Branches     7185     7184       -1     
==========================================
+ Hits        19286    19287       +1     
+ Misses      10506    10492      -14     
  Partials      166      166              
Impacted Files Coverage Δ
packages/app-core/src/ui/App/ViewMenu.tsx 83.33% <ø> (ø)
...w/src/LinearGenomeView/components/MiniControls.tsx 83.33% <80.00%> (+27.08%) ⬆️
packages/core/ui/CascadingMenuButton.tsx 100.00% <100.00%> (ø)
packages/embedded-core/src/ui/ViewMenu.tsx 100.00% <100.00%> (+54.54%) ⬆️
...iew/src/LinearGenomeView/components/TrackLabel.tsx 92.59% <100.00%> (-0.27%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@carolinebridge carolinebridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

@cmdcolin cmdcolin merged commit f3e2223 into main May 30, 2023
@cmdcolin cmdcolin deleted the cascading_menu_viewmenu branch May 30, 2023 13:37
cmdcolin added a commit that referenced this pull request Dec 7, 2023
cmdcolin added a commit that referenced this pull request Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sub menus can go off screen with LGV MiniControls
2 participants