Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some view menu checkboxes do not toggle properly #4115

Closed
cmdcolin opened this issue Dec 6, 2023 · 2 comments · Fixed by #4121
Closed

Some view menu checkboxes do not toggle properly #4115

cmdcolin opened this issue Dec 6, 2023 · 2 comments · Fixed by #4121
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

cmdcolin commented Dec 6, 2023

See breakpoint split view demo

I git bisected the bug to have been introduced in (#3731), so the bug has existed since v2.6.1 and worked in v2.5.0

@cmdcolin cmdcolin added the enhancement New feature or request label Dec 6, 2023
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 6, 2023

weirdly "Link views" checkbox works, but "Show intra-view links" does not. odd!

Screencast.from.2023-12-05.20-47-47.webm

@cmdcolin cmdcolin added bug Something isn't working and removed enhancement New feature or request labels Dec 7, 2023
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 7, 2023

I did some investigation into this and was still mystified a bit

it seems that the usage of CascadingMenu was not the true source of the problem, but the CascadingMenuButton might be...

here is a working example that uses CascadingMenu

here is diff between main->working
https://github.com/GMOD/jbrowse-components/compare/working-menu?expand=1

here is the diff between that working and non-working
https://github.com/GMOD/jbrowse-components/compare/working-menu..non-working-menu?expand=1

I am surprised by the second diff, as it's unclear to me why that makes it go from working to non-working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant