Fix website build #1450
Merged
Fix website build #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also only extract a caption if it's on the next line
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website currently won't build. This fixes the build and adds the website build to the root
yarn buildcommand so that if it breaks again it will show up in CI (website used to be built in CI before #1336).Some fixes are because there seems to a bug in docusaurus that if a markdown image alt-text has double quotes (like this:
), the build breaks: facebook/docusaurus#3751Another fix updates
tex_parser.mdso that it only tries to extract a caption for an image if there is no alt-text, and only extracts the caption if it's on the next line (no blank lines after it).