-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new embeddable React Circular Genome View #2163
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
- Coverage 61.77% 61.48% -0.30%
==========================================
Files 476 485 +9
Lines 22620 22901 +281
Branches 5303 5226 -77
==========================================
+ Hits 13974 14080 +106
- Misses 8365 8545 +180
+ Partials 281 276 -5
Continue to review full report at Codecov.
|
Should it be called just jbrowse-react-circular-view? |
Is the storybook online anywhere to look at yet? |
I was going for parallel naming to jbrowse-react-linear-genome-view
No, could possible add to |
I would be consistent with our current naming scheme, so I would say CircularView -> jbrowse-react-circular-view |
I'd prefer the package name be |
While it’s nice to keep it consistent with our internal naming, the external naming is more visible to users so keeping that consistent is probably a little more important. I’d vote for react-circular-genome-view |
This adds a React circular genome view component that is very similar to the React linear genome view component. It also includes a UMD build for plain-js embedding. See the README and example. Storybook is also included.
There is some duplication of components between this and the React LGV that could be factored out into a separate shared package.