Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore previous window location when re-opening on desktop #2241

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

garrettjstevens
Copy link
Collaborator

I've been using this change to make working on desktop easier, so I thought I'd put it in as a separate PR.

This adds electron-window-state, which keeps track of the size and location of the window is in when it closes in JBrowse Desktop. When you re-open JBrowse Desktop, it restores the window to the same size and position.

@garrettjstevens garrettjstevens added the enhancement New feature or request label Aug 20, 2021
@garrettjstevens garrettjstevens self-assigned this Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2241 (cf95a35) into main (5c8734c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
+ Coverage   62.89%   62.92%   +0.02%     
==========================================
  Files         484      484              
  Lines       22724    22724              
  Branches     5157     5157              
==========================================
+ Hits        14292    14298       +6     
+ Misses       8162     8156       -6     
  Partials      270      270              
Impacted Files Coverage Δ
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 87.65% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8734c...cf95a35. Read the comment docs.

@cmdcolin
Copy link
Collaborator

👍

@cmdcolin cmdcolin merged commit 397568e into main Aug 21, 2021
@cmdcolin
Copy link
Collaborator

just edited title to reflect it's on desktop

@cmdcolin cmdcolin changed the title Restore previous desktop window location when re-opening Restore previous window location when re-opening on desktop Aug 21, 2021
@cmdcolin cmdcolin deleted the electron_window_state branch August 21, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants