Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a configurable refNameColumn in RefNameAliasAdapter #2760

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #1775

Makes a configuration slot for saying which column from the ref name alias file is being configured

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 18, 2022
@cmdcolin cmdcolin changed the title Make a configurable refNameColumn Make a configurable refNameColumn in RefNameAliasAdapter Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #2760 (d607549) into main (ab41f01) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2760      +/-   ##
==========================================
- Coverage   60.63%   60.58%   -0.06%     
==========================================
  Files         566      566              
  Lines       26348    26350       +2     
  Branches     6422     6422              
==========================================
- Hits        15976    15964      -12     
- Misses      10047    10061      +14     
  Partials      325      325              
Impacted Files Coverage Δ
...fig/src/RefNameAliasAdapter/RefNameAliasAdapter.ts 92.30% <100.00%> (+1.39%) ⬆️
...s/svg/src/SvgFeatureRenderer/components/Chevron.js 87.17% <0.00%> (-10.26%) ⬇️
plugins/hic/src/HicRenderer/HicRenderer.tsx 95.45% <0.00%> (-4.55%) ⬇️
packages/core/TextSearch/TextSearchManager.ts 96.55% <0.00%> (-3.45%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 77.77% <0.00%> (-3.04%) ⬇️
packages/core/util/analytics.ts 89.79% <0.00%> (-2.05%) ⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 92.72% <0.00%> (-1.82%) ⬇️
...gFeatureRenderer/components/ProcessedTranscript.js 85.13% <0.00%> (-1.36%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 86.75% <0.00%> (-0.43%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.81% <0.00%> (-0.17%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab41f01...d607549. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 18, 2022
@cmdcolin cmdcolin merged commit beaac0e into main Feb 23, 2022
@cmdcolin cmdcolin deleted the configurable_refnamecolumn branch February 23, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refName aliasing does not work if refName for assembly is not first in alias file
2 participants