Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --clean argument to jbrowse upgrade to clean up old files #2761

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 18, 2022

Adds a --clean argument to jbrowse upgrade

Uses rimraf to clean the static directory

Fixes #2337

We could also consider making this the default behavior and not using --clean as an extra argument but it's maybe the 'safest' option since it would ensure that we don't delete anything unless a user confirms they want to delete stuff

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #2761 (0df0d00) into main (beaac0e) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

❗ Current head 0df0d00 differs from pull request most recent head af091d1. Consider uploading reports for the commit af091d1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2761      +/-   ##
==========================================
- Coverage   60.21%   60.19%   -0.03%     
==========================================
  Files         571      571              
  Lines       26590    26595       +5     
  Branches     6476     6477       +1     
==========================================
- Hits        16012    16008       -4     
- Misses      10253    10262       +9     
  Partials      325      325              
Impacted Files Coverage Δ
products/jbrowse-cli/src/commands/upgrade.ts 74.35% <25.00%> (-8.00%) ⬇️
products/jbrowse-cli/src/base.ts 82.50% <100.00%> (ø)
packages/core/TextSearch/TextSearchManager.ts 96.55% <0.00%> (-3.45%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 77.77% <0.00%> (-3.04%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.81% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beaac0e...af091d1. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 21, 2022
@garrettjstevens
Copy link
Collaborator

I like this idea, but I think having certain behaviors that rely on certain versions of Node is potentially confusing. I'd rather bump the version in "engines" in package.json (Node 12 is EOL in a couple months anyway), or use code that doesn't depend on Node 14.

@cmdcolin
Copy link
Collaborator Author

sounds reasonable, can probably use rimraf npm module for example

@cmdcolin cmdcolin merged commit 3fb9b68 into main Feb 24, 2022
@cmdcolin cmdcolin deleted the upgrade_clean branch February 24, 2022 19:35
@cmdcolin
Copy link
Collaborator Author

using rimraf now:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jbrowse upgrade does not clean up old worker files
2 participants