Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using global stats autoscale on wiggle tracks #2773

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

cmdcolin
Copy link
Collaborator

Currently the wiggle track fails to use get global stats with the error

TypeError: Cannot read properties of undefined (reading 'includes')
    at WiggleGetGlobalStats.execute (070fac713102893201a0.worker.js:253449:36)

This uses an older adapter capabilities concept. The code already checks for the adapter capabilities (using the adapterCapabilities attribute on the pluggable element) inside of linearwiggledisplay model correctly already so this check is unneeded

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 24, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #2773 (913d7d3) into main (a3795d2) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
+ Coverage   60.19%   60.25%   +0.05%     
==========================================
  Files         571      571              
  Lines       26594    26590       -4     
  Branches     6477     6475       -2     
==========================================
+ Hits        16009    16021      +12     
+ Misses      10260    10244      -16     
  Partials      325      325              
Impacted Files Coverage Δ
plugins/wiggle/src/WiggleRPC/rpcMethods.ts 60.60% <0.00%> (+6.55%) ⬆️
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.97% <0.00%> (+0.16%) ⬆️
packages/core/util/layouts/GranularRectLayout.ts 87.17% <0.00%> (+0.42%) ⬆️
...gFeatureRenderer/components/ProcessedTranscript.js 86.48% <0.00%> (+1.35%) ⬆️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 94.54% <0.00%> (+1.81%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 80.80% <0.00%> (+3.03%) ⬆️
packages/core/TextSearch/TextSearchManager.ts 100.00% <0.00%> (+3.44%) ⬆️
...s/svg/src/SvgFeatureRenderer/components/Chevron.js 97.43% <0.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3795d2...913d7d3. Read the comment docs.

@cmdcolin cmdcolin changed the title Fix using global stats autosclale on wiggle tracks Fix using global stats autoscale on wiggle tracks Feb 25, 2022
@cmdcolin cmdcolin merged commit 5cfbcbc into main Feb 25, 2022
@cmdcolin cmdcolin deleted the fix_global_stats_wiggle branch February 25, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant