-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new coloring options for dotplot and ability to "rectangularize" dotplot view #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Mar 7, 2022
adding similar coloring to the linear synteny view will likely be useful |
cmdcolin
added
enhancement
New feature or request
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Mar 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #2791 +/- ##
==========================================
- Coverage 60.11% 59.97% -0.15%
==========================================
Files 579 584 +5
Lines 26454 26651 +197
Branches 6388 6447 +59
==========================================
+ Hits 15903 15984 +81
- Misses 10226 10339 +113
- Partials 325 328 +3
Continue to review full report at Codecov.
|
after col 9, this let's us load score more reliably
…he GUI import forms for dotplot/synteny views (#2792) * Update mcscan anchors adapter to take a bed1Location and bed2Location * Standardize on left and right columns for mcscan anchors * Improve anchors importing * Add simple anchors example * Add simple anchors to import form * Update mcscan synteny config * Add delta example to grape vs peach dotplot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main features
Some riders:
As an example of the coloring, I added a coloring schemes the emulates D-GENIES (http://dgenies.toulouse.inra.fr/), which colors by "alignment identity" [1].
so, very similar behavior here in jbrowse and D-GENIES
the default is still black
[1] footnote: comparing with D-GENIES was a good way to guide some things to make sure things were done right but i did notice that alignment identity is a bit of a weird measure, see https://gist.github.com/cmdcolin/dbb1c6ae291d0e8282cfd0455f908fea still useful so included here