Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new coloring options for dotplot and ability to "rectangularize" dotplot view #2791

Merged
merged 26 commits into from
Mar 9, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 7, 2022

Main features

  • Adds more coloring options with a "colorBy" config variable in the dotplot renderer. This allows "identity", "mappingQuality", "strand", "none"
  • Ability to "rectangularize" the dotplot (make both axes display the same number of bp). Previously we added the ability to "square" the dotplot (make both axes have the same bpPerPx)

Some riders:

  • Internal: Codifies in more detail "query" vs "target" so that is it more clear in the PAF/delta/chain adapter
  • Adds a specialized mashmap adapter. previous the PAF adapter was modified to load MashMap type files but it does not have required columns 10 and 11 of PAF instead having a single score, so this makes it a different adapter type
  • Easier to read selection in dotplot header, so you know which assembly is which, how big the region you are viewing (displays 5Mbp instead of 5,000,000 for easier display) etc

As an example of the coloring, I added a coloring schemes the emulates D-GENIES (http://dgenies.toulouse.inra.fr/), which colors by "alignment identity" [1].

so, very similar behavior here in jbrowse and D-GENIES
Screenshot from 2022-03-06 16-44-55
Screenshot from 2022-03-06 13-47-11

the default is still black

[1] footnote: comparing with D-GENIES was a good way to guide some things to make sure things were done right but i did notice that alignment identity is a bit of a weird measure, see https://gist.github.com/cmdcolin/dbb1c6ae291d0e8282cfd0455f908fea still useful so included here

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 7, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Mar 7, 2022

adding similar coloring to the linear synteny view will likely be useful

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2791 (b7d24d6) into main (d897871) will decrease coverage by 0.14%.
The diff coverage is 46.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2791      +/-   ##
==========================================
- Coverage   60.11%   59.97%   -0.15%     
==========================================
  Files         579      584       +5     
  Lines       26454    26651     +197     
  Branches     6388     6447      +59     
==========================================
+ Hits        15903    15984      +81     
- Misses      10226    10339     +113     
- Partials      325      328       +3     
Impacted Files Coverage Δ
...parative-adapters/src/ChainAdapter/ChainAdapter.ts 0.00% <0.00%> (ø)
...parative-adapters/src/DeltaAdapter/DeltaAdapter.ts 0.00% <0.00%> (ø)
...tive-adapters/src/MashMapAdapter/MashMapAdapter.ts 0.00% <0.00%> (ø)
plugins/dotplot-view/src/DotplotDisplay/index.ts 71.79% <ø> (ø)
...ns/dotplot-view/src/DotplotView/components/util.ts 22.72% <0.00%> (-1.47%) ⬇️
...ew/src/LinearSyntenyView/components/ImportForm.tsx 0.00% <0.00%> (ø)
...inearGenomeView/components/LinearGenomeViewSvg.tsx 91.02% <ø> (+1.49%) ⬆️
...SimpleAnchorsAdapter/MCScanSimpleAnchorsAdapter.ts 1.96% <1.96%> (ø)
...dotplot-view/src/DotplotView/components/Header.tsx 37.50% <23.07%> (-5.36%) ⬇️
...ot-view/src/DotplotView/components/DotplotView.tsx 54.66% <27.86%> (+7.29%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d897871...b7d24d6. Read the comment docs.

@cmdcolin cmdcolin merged commit 795b30d into main Mar 9, 2022
@cmdcolin cmdcolin deleted the dotplot_mods branch March 9, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant