Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit process after rendering to speed up jb2export #2799

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

Currently running jb2export will finish quickly and print out "Finished rendering 1.24s" for example, but the process will stay running. This may be due to an autorun or something keeping nodejs alive.

We could try to dig into why it is kept alive, but doing a process.exit after the image is generated seems reasonable also

This would fix an older issue open at GMOD/jb2export#6

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 13, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 13, 2022
@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #2799 (1199112) into main (5fc0460) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 1199112 differs from pull request most recent head 8cb0ed5. Consider uploading reports for the commit 8cb0ed5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
- Coverage   59.97%   59.96%   -0.02%     
==========================================
  Files         584      584              
  Lines       26658    26665       +7     
  Branches     6450     6451       +1     
==========================================
  Hits        15989    15989              
- Misses      10341    10347       +6     
- Partials      328      329       +1     
Impacted Files Coverage Δ
products/jbrowse-img/src/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc0460...8cb0ed5. Read the comment docs.

@cmdcolin cmdcolin changed the title Exit process faster after rendering complete for jb2export Exit process after rendering to speed up jb2export Mar 14, 2022
@cmdcolin cmdcolin merged commit 541241d into main Mar 14, 2022
@cmdcolin cmdcolin deleted the faster_jbimg branch March 14, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant