Allow user to specify number of workers #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjstevens
added
bug
cmdcolin
reviewed
Mar 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #2829 +/- ##
=======================================
Coverage 59.98% 59.99%
=======================================
Files 584 584
Lines 26688 26695 +7
Branches 6462 6467 +5
=======================================
+ Hits 16010 16016 +6
- Misses 10350 10351 +1
Partials 328 328
Continue to review full report at Codecov.
|
cmdcolin
pushed a commit
that referenced
this pull request
Mar 18, 2022
* Fix bug where too many workers were created * Add ability to specify workerCount in config * Fix name of base rpc driver config schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered with @cmdcolin yesterday, there was a
workerCountproperty inBaseRpcDriverthat was set to 0 and had no way to change it, meaning the worker count was always auto-calculated. We also realized that the config for the worker was not getting passed to the worker driver. This fixes that by passing the worker configs to the drivers and then readingworkerCountout of the config. You can specify a certain number of workers like this:{ "configuration": { "rpc": { "drivers": { "WebWorkerRpcDriver": { "type": "WebWorkerRpcDriver", "workerCount": 2 } } } } }This also contains a bug fix related to #2798. As a consequence of that change, if you had a lot of tracks open when the page loaded, it would sometimes create some unused workers, but this PR fixes that.