Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid drawing intron subfeatures for gene glyphs #2849

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #2735

Uses a heuristic that doesn't draw introns only if the feature is a subfeature

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #2849 (1ac6564) into main (b11ba74) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2849      +/-   ##
==========================================
- Coverage   59.90%   59.88%   -0.02%     
==========================================
  Files         584      584              
  Lines       26528    26529       +1     
  Branches     6443     6445       +2     
==========================================
- Hits        15892    15888       -4     
- Misses      10322    10327       +5     
  Partials      314      314              
Impacted Files Coverage Δ
...gins/svg/src/SvgFeatureRenderer/components/Box.tsx 100.00% <100.00%> (ø)
packages/core/TextSearch/TextSearchManager.ts 96.55% <0.00%> (-3.45%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 77.77% <0.00%> (-3.04%) ⬇️
packages/core/util/analytics.ts 89.79% <0.00%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11ba74...1ac6564. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 23, 2022
@cmdcolin cmdcolin changed the title Don't draw intron subfeatures for gene glyphs Avoid drawing intron subfeatures for gene glyphs Mar 23, 2022
@cmdcolin cmdcolin merged commit 8f5a045 into main Mar 23, 2022
@cmdcolin cmdcolin deleted the dont_draw_intron_subfeatures branch March 23, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvgFeatureRenderer draws "intron" features
1 participant