-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to MUI v5, mobx-state-tree v5, mobx-react v6, mobx-react v7 #2949
Conversation
… defaultProps. Also make snackbar horizontally centered
Looks like that error was fixed, but now I'm getting this one:
I'm not sure what that's from. If you want to check it out, that step doesn't need an Apollo server set up so you can start up the plugin by:
|
I changed up the "makeStyles adapter" so I think the apollo plugin will produce the proper styling now The crash is also due to using color="default" on the Button component, if this is removed the crash is fixed. We could probably add a workaround in the ReExports to avoid the crash if needed, but might be easier to just fix in the plugin |
short note about color="default" https://mui.com/material-ui/migration/v5-component-changes/#%E2%9C%85-remove-default-color-prop |
After removing the |
Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>
awesome 🥳 really glad to hear it works with apollo :) |
This is a draft PR to upgrade to using MUI v5. A large change, but generally is approaching working state
There is a small amount of back-compatibility for plugins that might use MUIv4 by using ReExports to export the @mui/material namespace into @material-ui/core, so plugins using v4 with @material-ui/core can still load (MSAView is an example of this and it still loads)
Some benefits
Some remaining todos
Example link
https://jbrowse.org/code/jb2/mui5/?config=test_data%2Fvolvox%2Fconfig.json&session=share-V0DO6dUvkA&password=qsULt