Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewing soft/hardclip indicator in some regions #2951

Merged
merged 1 commit into from
May 16, 2022

Conversation

cmdcolin
Copy link
Collaborator

Small detail, but we are able to capture a clip indicator when it goes "past the feature end" (the soft clips are technically not stored interbase, so to get them, we need to go past the feature end)

demo

main
https://jbrowse.org/code/jb2/main/?config=test_data%2Fvolvox%2Fconfig.json&session=share-fBa97hv8H8&password=YL7ng

this branch
https://jbrowse.org/code/jb2/clip_indicator_cliff/?config=test_data%2Fvolvox%2Fconfig.json&session=share-fBa97hv8H8&password=YL7ng

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 15, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #2951 (a14a843) into main (0738c41) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
- Coverage   60.70%   60.68%   -0.02%     
==========================================
  Files         601      601              
  Lines       27341    27341              
  Branches     6654     6654              
==========================================
- Hits        16597    16592       -5     
- Misses      10435    10440       +5     
  Partials      309      309              
Impacted Files Coverage Δ
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 56.37% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 81.81% <0.00%> (-3.04%) ⬇️
packages/core/TextSearch/TextSearchManager.ts 89.18% <0.00%> (-2.71%) ⬇️
...ckages/core/pluggableElementTypes/RpcMethodType.ts 83.33% <0.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0738c41...a14a843. Read the comment docs.

@cmdcolin cmdcolin merged commit 58a7a4d into main May 16, 2022
@cmdcolin cmdcolin deleted the clip_indicator_cliff branch May 16, 2022 18:43
@cmdcolin cmdcolin changed the title Allow getting clip indicator after feature end Fix viewing soft/hardclip indicator in some regions May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant