Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link on yeast synteny demo and fix CIGAR rendering on dotplot #2969

Merged
merged 1 commit into from
May 20, 2022

Conversation

cmdcolin
Copy link
Collaborator

The CIGAR rendering on dotplot was not working after refactoring made awhile back, this restores it though!

It uses a path with multiple lineTo inside the loop, and a single stroke for all the segments of the line

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 20, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2969 (52caaf3) into main (c3b9b3e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2969   +/-   ##
=======================================
  Coverage   60.67%   60.67%           
=======================================
  Files         601      601           
  Lines       27373    27373           
  Branches     6675     6675           
=======================================
  Hits        16609    16609           
  Misses      10454    10454           
  Partials      310      310           
Impacted Files Coverage Δ
...otplot-view/src/DotplotRenderer/DotplotRenderer.ts 60.80% <0.00%> (ø)
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b9b3e...52caaf3. Read the comment docs.

@cmdcolin cmdcolin merged commit b3d2d09 into main May 20, 2022
@cmdcolin cmdcolin deleted the fix_cigar_dotplot branch May 20, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant