Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescripting to hierarchical track selector #3035

Merged
merged 7 commits into from
Jun 15, 2022

Conversation

cmdcolin
Copy link
Collaborator

Begins adding a little type safety to hierarchical track selector, which has long been un-typescripted :)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3035 (6fa8420) into main (cb6f2f0) will increase coverage by 0.06%.
The diff coverage is 64.23%.

@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
+ Coverage   61.64%   61.70%   +0.06%     
==========================================
  Files         590      590              
  Lines       26924    26920       -4     
  Branches     6522     6528       +6     
==========================================
+ Hits        16598    16612      +14     
+ Misses      10020    10005      -15     
+ Partials      306      303       -3     
Impacted Files Coverage Δ
...electorWidget/components/CloseConnectionDialog.tsx 0.00% <0.00%> (ø)
...lectorWidget/components/DeleteConnectionDialog.tsx 0.00% <ø> (ø)
...ectorWidget/components/ManageConnectionsDialog.tsx 0.00% <ø> (ø)
...ectorWidget/components/ToggleConnectionsDialog.tsx 0.00% <0.00%> (ø)
...ement/src/HierarchicalTrackSelectorWidget/index.ts 100.00% <ø> (ø)
...roducts/jbrowse-desktop/src/sessionModelFactory.ts 6.25% <0.00%> (+0.11%) ⬆️
...ement/src/HierarchicalTrackSelectorWidget/model.ts 67.79% <64.91%> (ø)
...torWidget/components/HierarchicalTrackSelector.tsx 64.17% <76.31%> (ø)
packages/core/util/types/index.ts 68.60% <100.00%> (+0.74%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6f2f0...6fa8420. Read the comment docs.

@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 14, 2022
@cmdcolin cmdcolin marked this pull request as ready for review June 15, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant