-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ability to search and load data files using lower case refName aliases #3041
Conversation
Fixes #3039 |
Codecov Report
@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
+ Coverage 61.70% 61.78% +0.08%
==========================================
Files 590 590
Lines 26915 26912 -3
Branches 6526 6525 -1
==========================================
+ Hits 16607 16627 +20
+ Misses 10005 9982 -23
Partials 303 303
Continue to review full report at Codecov.
|
fff0e08
to
68ea203
Compare
this doesn't support queries like chrmt:1-100, but it could be a starter |
allows lowercase locstrings now, and also allows data files with either Chr1 or chr1. various tests added also to try to cover these cases, with a bit of refactoring to help the import form's search box to use the same fetchResults utility as the lgv header search box |
2126af2
to
8d1f8a0
Compare
Currently, you can query for lower case ref names such as e.g. ctga:1-100 on volvox, but with refnamealiases it does not work. E.g. contiga:1-100 fails
This fixes it so that you can use lower case naming in the refname autocomplete for searching
Small amount of other refactoring code in PR, and adding chrMT to hg19 refname aliases