Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening link in new tab by default in feature details #3064

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3063 #3063

The useEffect didn't work as expected, so this PR changes the code to run it in the renderer routine to get expected behavior

@cmdcolin cmdcolin changed the title Fix open in new tab Fix open in new tab in feature details Jun 28, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 28, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 28, 2022
@cmdcolin cmdcolin changed the title Fix open in new tab in feature details Fix opening link in new tab by default in feature details Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3064 (9eb71bb) into main (912fdb8) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 9eb71bb differs from pull request most recent head 48d3447. Consider uploading reports for the commit 48d3447 to get more accurate results

@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
- Coverage   61.51%   61.51%   -0.01%     
==========================================
  Files         591      591              
  Lines       26980    26979       -1     
  Branches     6527     6527              
==========================================
- Hits        16598    16597       -1     
  Misses      10085    10085              
  Partials      297      297              
Impacted Files Coverage Δ
packages/core/ui/SanitizedHTML.tsx 85.71% <66.66%> (-0.96%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912fdb8...48d3447. Read the comment docs.

@cmdcolin cmdcolin force-pushed the fix_open_in_new_tab branch from 9eb71bb to 48d3447 Compare June 28, 2022 17:12
@cmdcolin cmdcolin merged commit 7935404 into main Jun 28, 2022
@cmdcolin cmdcolin deleted the fix_open_in_new_tab branch June 28, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links not initially defaulting to new tab
1 participant