Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the display of deletions vs insertions being backwards in synteny view with CIGAR strings #3074

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jul 7, 2022

Was seen because the mouseover, worked on in #3071 does not incorporate CIGARs, just using feature.start and feature.end but it did not match up with what the CIGAR renderings were showing. Flipping the orientation of insertions and deletions fixes the issue

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 7, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 7, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jul 7, 2022

what is seen

after
Screenshot from 2022-07-07 13-28-17

before
Screenshot from 2022-07-07 13-28-24

way to think about the fix: top is the query, bottom is target, so the insertion is "extra sequence the query has relative to the target" and deletion is "extra sequence in the target relative to the query"

@cmdcolin cmdcolin merged commit 2f663b9 into main Jul 7, 2022
@cmdcolin cmdcolin deleted the fix_cigar_query_vs_ref branch July 7, 2022 19:36
@cmdcolin cmdcolin added the bug Something isn't working label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant