Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zoom to behavior being inaccurate with many displayed regions visible #3085

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3083

This is a one-liner fix in the LGV model with a couple of fixed tests

Intuitively using the app gives reasonable values for rubberband selections (which are the primary user of the moveTo function that we fix here) even with many displayed regions visible (which commonly occurs with show all regions and synteny views)

https://jbrowse.org/code/jb2/fix_zoomto/?config=test_data%2Fconfig_dotplot.json&session=share-qZrNF9OGYz&password=MMo0X can be tested and appear to work ok

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 11, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #3085 (319e1a1) into main (d10927a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3085   +/-   ##
=======================================
  Coverage   61.34%   61.34%           
=======================================
  Files         594      594           
  Lines       27282    27282           
  Branches     6601     6601           
=======================================
  Hits        16735    16735           
  Misses      10249    10249           
  Partials      298      298           
Impacted Files Coverage Δ
.../linear-genome-view/src/LinearGenomeView/index.tsx 84.28% <100.00%> (ø)
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10927a...319e1a1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation with rubberband in synteny view on horizontally flipped mode can be inaccurate
1 participant