Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "emphasis" mode for no fill/scatterplot mode in XYPlot type renderings #3106

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

cmdcolin
Copy link
Collaborator

Currently we have the "no fill" mode on XYPlotRenderer type tracks

This helps draw a scatterplot style rendering

It can be useful to emphasize those scatterplot points, so this PR adds an "emphasis" setting that is toggleable

Screenshot from 2022-07-22 12-18-57
current main: all the no-fill points are quite tiny

Screenshot from 2022-07-22 12-18-02
this branch: emphasis mode makes points 2px in size

… lgv test. Flakyness is due to import-after-jest-test-finished because of async import in pileuprenderer of volvox alignments, which is removed here
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 22, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #3106 (50dc97e) into main (a744a1e) will decrease coverage by 0.02%.
The diff coverage is 28.81%.

❗ Current head 50dc97e differs from pull request most recent head 1e24174. Consider uploading reports for the commit 1e24174 to get more accurate results

@@            Coverage Diff             @@
##             main    #3106      +/-   ##
==========================================
- Coverage   58.92%   58.90%   -0.03%     
==========================================
  Files         640      640              
  Lines       28807    28837      +30     
  Branches     6985     6993       +8     
==========================================
+ Hits        16974    16985      +11     
- Misses      11450    11470      +20     
+ Partials      383      382       -1     
Impacted Files Coverage Δ
...ugins/wiggle/src/MultiLineRenderer/configSchema.ts 100.00% <ø> (ø)
...ggle/src/MultiLinearWiggleDisplay/models/model.tsx 2.11% <0.00%> (-0.11%) ⬇️
...ns/wiggle/src/MultiRowLineRenderer/configSchema.ts 100.00% <ø> (ø)
.../wiggle/src/MultiRowXYPlotRenderer/configSchema.ts 100.00% <ø> (ø)
...ins/wiggle/src/MultiXYPlotRenderer/configSchema.ts 100.00% <ø> (ø)
plugins/wiggle/src/XYPlotRenderer/configSchema.ts 100.00% <ø> (ø)
...ns/wiggle/src/LinearWiggleDisplay/models/model.tsx 70.72% <34.78%> (-1.40%) ⬇️
...c/LinearGenomeView/components/LinearGenomeView.tsx 88.88% <50.00%> (+2.68%) ⬆️
plugins/wiggle/src/drawxy.ts 71.10% <88.88%> (+0.67%) ⬆️
plugins/alignments/src/BamAdapter/BamAdapter.ts 72.07% <0.00%> (-0.91%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cmdcolin cmdcolin force-pushed the no_fill_with_emphasis branch from 50dc97e to fb7ef12 Compare July 22, 2022 19:10
@cmdcolin cmdcolin force-pushed the no_fill_with_emphasis branch from fb7ef12 to 1e24174 Compare July 22, 2022 19:11
@cmdcolin cmdcolin changed the title Add "emphasis" mode on scatterplot (filled:false) mode to XYPlotRenderer Add "emphasis" mode for no fill/scatterplot mode in XYPlot type renderings Jul 22, 2022
@cmdcolin cmdcolin merged commit 18290ec into main Jul 22, 2022
@cmdcolin cmdcolin deleted the no_fill_with_emphasis branch July 22, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant