Better support for developing plugins from within yarn 2+ workspaces (include __virtual folder in build) #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for shared packages in yarn 4 workspaces, where the resolved path does not contain node_modules, but they still need to be treated as external modules.
Codecov Report
@@ Coverage Diff @@
## main #3109 +/- ##
==========================================
- Coverage 58.91% 58.89% -0.02%
==========================================
Files 640 640
Lines 28843 28843
Branches 6999 6999
==========================================
- Hits 16992 16987 -5
- Misses 11469 11474 +5
Partials 382 382
Help us with your feedback. Take ten seconds to tell us how you rate us. |
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In yarn 2+ workspaces, packages that are shared in the workspace don't show up under
node_modules, they show up under a__virtual__folder. This adds handling of that to the plugin rollup config, so that shared workspace packages are processed by rollup correctly.