-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning when dotplot renders outside of it's boundaries, and create click-and-drag panning of dotplot view #3115
Conversation
Slight offset in the mouseover position on dotplot view Remove the nocache webpack config Typescriptify svg features test
in the current codebase this already had a console.warn for developers but this makes it more visible in the UI, and also adds an extra check when the CIGAR string in particular triggers this condition |
also allows a click-and-drag to pan the view now. I was heavily biased by having a trackpad with all-direction wheel scroll but having the click and drag to pan view is likely helpful for mouse users still can't upload pictures to post |
Codecov Report
@@ Coverage Diff @@
## main #3115 +/- ##
==========================================
- Coverage 58.88% 58.85% -0.03%
==========================================
Files 644 647 +3
Lines 28895 28940 +45
Branches 7017 7030 +13
==========================================
+ Hits 17016 17034 +18
- Misses 11501 11526 +25
- Partials 378 380 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There are situations with our dotplot view where if it renders outside it's boundaries, it can indicate that the wrong assemblies are being used, or that the query and target are backwards. This PR adds a warning in the dotplot view header to help protect against that
The github image uploader isn't working for me so here is an alternative link https://imgur.com/a/C2FI3Ru