Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when dotplot renders outside of it's boundaries, and create click-and-drag panning of dotplot view #3115

Merged
merged 16 commits into from
Jul 27, 2022

Conversation

cmdcolin
Copy link
Collaborator

There are situations with our dotplot view where if it renders outside it's boundaries, it can indicate that the wrong assemblies are being used, or that the query and target are backwards. This PR adds a warning in the dotplot view header to help protect against that

The github image uploader isn't working for me so here is an alternative link https://imgur.com/a/C2FI3Ru

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 27, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 27, 2022
@cmdcolin
Copy link
Collaborator Author

in the current codebase this already had a console.warn for developers but this makes it more visible in the UI, and also adds an extra check when the CIGAR string in particular triggers this condition

@cmdcolin
Copy link
Collaborator Author

also allows a click-and-drag to pan the view now. I was heavily biased by having a trackpad with all-direction wheel scroll but having the click and drag to pan view is likely helpful for mouse users

still can't upload pictures to post

https://imgur.com/a/6FN6IpY

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #3115 (d2f5eb4) into main (8d58870) will decrease coverage by 0.02%.
The diff coverage is 54.98%.

@@            Coverage Diff             @@
##             main    #3115      +/-   ##
==========================================
- Coverage   58.88%   58.85%   -0.03%     
==========================================
  Files         644      647       +3     
  Lines       28895    28940      +45     
  Branches     7017     7030      +13     
==========================================
+ Hits        17016    17034      +18     
- Misses      11501    11526      +25     
- Partials      378      380       +2     
Impacted Files Coverage Δ
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 74.41% <0.00%> (+1.27%) ⬆️
packages/core/util/index.ts 84.33% <0.00%> (-1.24%) ⬇️
...rc/DotplotRenderer/components/DotplotRendering.tsx 100.00% <ø> (ø)
plugins/dotplot-view/src/DotplotRenderer/index.ts 100.00% <ø> (ø)
...-view/src/DotplotView/components/WarningDialog.tsx 0.00% <0.00%> (ø)
...iggleDisplay/components/WiggleDisplayComponent.tsx 8.64% <0.00%> (-0.11%) ⬇️
...ggle/src/MultiLinearWiggleDisplay/models/model.tsx 2.11% <ø> (ø)
...dotplot-view/src/DotplotView/components/Header.tsx 43.75% <34.61%> (+6.25%) ⬆️
...ot-view/src/DotplotView/components/DotplotView.tsx 48.61% <45.65%> (-6.06%) ⬇️
...lot-view/src/DotplotView/components/CursorIcon.tsx 50.00% <50.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cmdcolin cmdcolin merged commit fb30ca5 into main Jul 27, 2022
@cmdcolin cmdcolin deleted the dotplot_tests branch July 27, 2022 21:29
@cmdcolin cmdcolin changed the title Add warning when dotplot renders outside of it's boundaries Add warning when dotplot renders outside of it's boundaries, and create click-and-drag panning of dotplot view Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant