Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend theme with module augmentation #3132

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Conversation

garrettjstevens
Copy link
Collaborator

This uses module augmentation to add the tertiary, quaternary, and base colors to our theme in TypeScript. This way, we can get rid of the @ts-ignores that are used whenever the tertiary, quaternary, or base colors are referenced.

@garrettjstevens garrettjstevens added the enhancement New feature or request label Aug 11, 2022
@garrettjstevens garrettjstevens self-assigned this Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3132 (984fe33) into main (ad9bf14) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
- Coverage   58.81%   58.79%   -0.03%     
==========================================
  Files         648      648              
  Lines       29042    29042              
  Branches     7067     7067              
==========================================
- Hits        17082    17075       -7     
- Misses      11581    11588       +7     
  Partials      379      379              
Impacted Files Coverage Δ
packages/core/ui/theme.ts 83.33% <ø> (ø)
...s/alignments/src/PileupRenderer/PileupRenderer.tsx 50.40% <ø> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 73.38% <ø> (ø)
...r-view/src/BaseChordDisplay/components/Loading.tsx 92.85% <ø> (ø)
...ierarchicalTrackSelectorWidget/components/Node.tsx 61.90% <ø> (ø)
...PluginStoreWidget/components/PluginStoreWidget.tsx 77.77% <ø> (ø)
...t/src/JobsListWidget/components/JobsListWidget.tsx 5.88% <ø> (ø)
...c/LinearGenomeView/components/OverviewScaleBar.tsx 64.51% <ø> (ø)
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) ⬇️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.55% <0.00%> (-5.56%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator

looks good :)

@cmdcolin cmdcolin merged commit 1b67991 into main Aug 19, 2022
@cmdcolin cmdcolin deleted the theme_module_augmentation branch August 19, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants