Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript the QuickLRU module in @jbrowse/core #3164

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

This copies quick-lru code directly into our codebase so that we can use the latest version, with it's .d.ts typescript definitions

Then it applies a couple typescripting changes throughout the code to make this work (refactor indexedfasta, assemblymanager)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 26, 2022
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #3164 (75f61e1) into main (d487b58) will increase coverage by 0.77%.
The diff coverage is 92.10%.

@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
+ Coverage   58.68%   59.46%   +0.77%     
==========================================
  Files         668      667       -1     
  Lines       29139    28606     -533     
  Branches     7088     6923     -165     
==========================================
- Hits        17101    17010      -91     
+ Misses      11660    11275     -385     
+ Partials      378      321      -57     
Impacted Files Coverage Δ
packages/core/rpc/coreRpcMethods.ts 80.45% <ø> (ø)
packages/core/util/index.ts 84.41% <ø> (+0.23%) ⬆️
plugins/alignments/src/PileupRPC/rpcMethods.ts 51.21% <ø> (ø)
plugins/wiggle/src/WiggleRPC/rpcMethods.ts 36.36% <ø> (ø)
...nce/src/IndexedFastaAdapter/IndexedFastaAdapter.ts 84.78% <80.76%> (+3.38%) ⬆️
packages/core/TextSearch/TextSearchManager.ts 97.05% <96.00%> (+5.16%) ⬆️
packages/core/assemblyManager/assembly.ts 92.25% <100.00%> (ø)
plugins/dotplot-view/src/extensionPoints.ts 100.00% <100.00%> (ø)
plugins/dotplot-view/src/index.ts 100.00% <100.00%> (ø)
...equence/src/BgzipFastaAdapter/BgzipFastaAdapter.ts 100.00% <100.00%> (+23.07%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 4b422e7 into main Aug 29, 2022
@cmdcolin cmdcolin deleted the typescript_lru branch August 29, 2022 21:13
cmdcolin added a commit that referenced this pull request Sep 14, 2022
* Remove some deps

* Typescript quick-lru

* Reproduce license

* Misc

* Ignore some vendored code for code coverage purposes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant