Fix "dead state tree node" error by creating snapshots of parent region for block calculations #3182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a relatively reproducible procedure to create the dead state tree node error, and a probable fix for this particular case
A good portion of the time, this produces the error in #3181
I found that the "parentRegion" attribute in the static/dynamic blocks were not snapshots and were instead proxies for the state tree node, creating this error
Note that this change could mildly slow down the block calculations. Note also that parentRegion is not even used anywhere in our codebase, but have some hypothetical use cases
Fixes #3181