-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading tracks from connection using assembly alias #3217
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
+ Coverage 59.40% 59.45% +0.04%
==========================================
Files 673 674 +1
Lines 28797 28778 -19
Branches 6985 6982 -3
==========================================
+ Hits 17108 17111 +3
- Misses 11368 11372 +4
+ Partials 321 295 -26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bbb63de
to
72c43e0
Compare
I also propose in this PR, in the "Toggle connections" dialog, to make it display all connections and not just assembly-specific connections (and to display the assembly names it applies to next to the connection name) |
75a6b91
to
00b0fb2
Compare
00b0fb2
to
4ede1d5
Compare
This fixes a bug I found with loading tracks from a connection that uses "assembly aliases" e.g. it thinks the hub is from GRCh37 but we are on an assembly named hg19
The current main branch does not display these tracks into the track list, this branch fixes that
It also does a number of refactors and typescripting
Example refactors