Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local session failing to load copying between tabs in some cases #3241

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Oct 1, 2022

Fixes #3240

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 1, 2022
@@ -416,6 +414,17 @@ const SessionLoader = types
return
}

if (self.bc1) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main fix, here: moving this broadcast channel listener up

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #3241 (5d37dc1) into main (a602dc9) will decrease coverage by 0.22%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
- Coverage   59.41%   59.19%   -0.23%     
==========================================
  Files         674      674              
  Lines       28783    28781       -2     
  Branches     7009     7008       -1     
==========================================
- Hits        17101    17036      -65     
- Misses      11407    11460      +53     
- Partials      275      285      +10     
Impacted Files Coverage Δ
products/jbrowse-web/src/SessionLoader.ts 61.30% <7.69%> (+0.52%) ⬆️
plugins/data-management/src/ucsc-trackhub/model.js 30.76% <0.00%> (-46.16%) ⬇️
.../data-management/src/ucsc-trackhub/ucscTrackHub.js 4.68% <0.00%> (-28.13%) ⬇️
...eElementTypes/models/BaseConnectionModelFactory.ts 56.25% <0.00%> (-18.75%) ⬇️
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) ⬇️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 77.50% <0.00%> (-5.00%) ⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 91.83% <0.00%> (-4.09%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (-1.67%) ⬇️
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <0.00%> (-1.41%) ⬇️
plugins/alignments/src/BamAdapter/BamAdapter.ts 72.07% <0.00%> (-0.91%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin force-pushed the fix_local_session_err branch from 89a608a to 15310b4 Compare October 1, 2022 18:53
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 1, 2022
@cmdcolin cmdcolin force-pushed the fix_local_session_err branch from 15310b4 to 5d37dc1 Compare October 1, 2022 20:52
@cmdcolin cmdcolin merged commit cb82038 into main Oct 1, 2022
@cmdcolin cmdcolin deleted the fix_local_session_err branch October 1, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant