Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more docs about color callbacks #3255

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Add more docs about color callbacks #3255

merged 1 commit into from
Oct 11, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Oct 8, 2022

Makes a note about how a custom function for jexl color callbacks is a little different from the jexl function for feature details, and adds a link to FAQ

Also makes the indentation a little less on FAQ, so the sidebar/TOC works better

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 8, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Oct 8, 2022

Also, explains that the "small plugins" that you create with this method do not have to use jbrowse-plugin-template

@cmdcolin cmdcolin added documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 8, 2022
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #3255 (bd283b9) into main (5eaa86a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3255      +/-   ##
==========================================
- Coverage   59.41%   59.39%   -0.03%     
==========================================
  Files         674      674              
  Lines       28782    28782              
  Branches     7008     7008              
==========================================
- Hits        17101    17094       -7     
- Misses      11406    11413       +7     
  Partials      275      275              
Impacted Files Coverage Δ
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) ⬇️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 77.50% <0.00%> (-5.00%) ⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 91.83% <0.00%> (-4.09%) ⬇️
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <0.00%> (-1.41%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 86.86% <0.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 4018477 into main Oct 11, 2022
@cmdcolin cmdcolin deleted the color_callbacks_docs branch October 11, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants