Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bbi-js for bugfix on webpack 4 #3274

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Update bbi-js for bugfix on webpack 4 #3274

merged 1 commit into from
Oct 15, 2022

Conversation

cmdcolin
Copy link
Collaborator

In GMOD/bbi-js#50 I found that bbi can receive plain Uint8Array objects, and then we would not want to use the Buffer::toString on them (Buffer is a subclass of Uint8Array with a special toString to transform e.g. to utf8, but plain Uint8Array does not have a toString method that does this, have to use TextDecoder)

bbi already got this fix and this PR just adds some more demo tracks to various projects, and updates the yarn.lock to get the bbi update

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 15, 2022
@cmdcolin
Copy link
Collaborator Author

don't know exactly why webpack 4 was affected, probably differences between how the buffer polyfill works in webpack 4 and webpack 5 (we manually do the polyfill in webpack 5, whereas it's provided by webpack in webpack 4) but this fix just avoids the buffer polyfill using TextDecoder manually

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Oct 15, 2022

error seen before this fix was added, found by @teresam856

Screenshot from 2022-10-15 14-27-27

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 15, 2022
@cmdcolin cmdcolin merged commit 978c678 into main Oct 15, 2022
@cmdcolin cmdcolin deleted the bump_bbi branch October 15, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant