Update to mui x-data-grid 6 #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
mui_data_grid_6
branch
2 times, most recently
from
ecb8c80 to
5034b7c
Compare
Codecov Report
@@ Coverage Diff @@
## main #3626 +/- ##
==========================================
- Coverage 63.06% 63.06% -0.01%
==========================================
Files 871 871
Lines 30189 30184 -5
Branches 7269 7273 +4
==========================================
- Hits 19039 19035 -4
+ Misses 10965 10964 -1
Partials 185 185
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
force-pushed
the
mui_data_grid_6
branch
from
98427eb to
6b659c6
Compare
|
I think this should be good to go. I requested @garrettjstevens review since i think apollo uses the data-grid, but i imagine that it would just involve updating a couple props in various places |
|
maybe can merge for now |
|
Was able to look at this now, a few changes were needed: GMOD/Apollo3#200. |
cmdcolin
added a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the react 18 branch stalled and included some code for the @mui/x-data-grid 6 update, this just splits it out from there #3502
some APIs are renamed, including the things like selectionModel->rowSelectionModel. Hopefully not too impactful on plugins though