Typescript checking for config slot names #3629
Conversation
github-actions
bot
added
the
needs label triage
rbuels
added
internal
and removed
needs label triage
rbuels
changed the title
rbuels
force-pushed
the
configuration-typescript
branch
2 times, most recently
from
9207dfb to
ed6001d
Compare
* improve readConfObject ts for slot names * slot name checking support for explicitIdentifier * move mouseover config slot in linear from LinearBasicDisplay to BaseLinearDisplay config schema * remove some commented code and typos * change most things to import config things from @jbrowse/core/configuration top-level * ts checking of base-conf working
rbuels
force-pushed
the
configuration-typescript
branch
from
ed6001d to
9ee6eb9
Compare
|
rebased and squashed just now onto main. @cmdcolin does this look OK to merge now? |
| const refNameAliasesAdapterConf = conf.refNameAliases?.adapter | ||
| const cytobandAdapterConf = conf.cytobands?.adapter | ||
| const sequenceAdapterConf = conf.sequence.adapter | ||
| const refNameAliasesAdapterConf = conf?.refNameAliases?.adapter |
There was a problem hiding this comment.
any reason for additional undefined checks?
There was a problem hiding this comment.
Yes, TS found that some of those things can be undefined
There was a problem hiding this comment.
I see that the configuration is a safeReference so that could be indeed possibly undefined, but my editor says self.configuration is type any so wonder if it regressed back to any somehow
There was a problem hiding this comment.
yeah it did regress back, somehow, let me see if I can improve the types there
There was a problem hiding this comment.
Actually, upon looking into it further, I don't think it did regress, I think I may have been using a different version of TS or mst that caught that error
There was a problem hiding this comment.
can you identify which versions? the repo of course has the lock file, and ts/mst versions haven't changed substantially for awhile
Codecov Report
@@ Coverage Diff @@
## main #3629 +/- ##
=======================================
Coverage 63.06% 63.07%
=======================================
Files 877 877
Lines 30167 30168 +1
Branches 7272 7271 -1
=======================================
+ Hits 19026 19028 +2
+ Misses 10956 10955 -1
Partials 185 185
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
should be ok |
cmdcolin
changed the title
This PR adds type checking of config slot names to the configuration system TS. It can figure out the specific config schema surprisingly often.
Other things in this PR: