Fix flakyness of connection test #3630
Conversation
github-actions
bot
added
the
needs label triage
cmdcolin
force-pushed
the
connection_changes
branch
from
6a9e9b0 to
36fa0c0
Compare
cmdcolin
force-pushed
the
connection_changes
branch
from
36fa0c0 to
7834df6
Compare
| : false, | ||
| ) | ||
|
|
||
| const conf = session.assemblyManager.get(genomeName)?.configuration |
There was a problem hiding this comment.
updated from PR #3625 which actually needed more parenthesizing in it's current form, and should be easier with this method
cmdcolin
added
bug
Codecov Report
@@ Coverage Diff @@
## main #3630 +/- ##
==========================================
+ Coverage 62.94% 63.06% +0.12%
==========================================
Files 871 871
Lines 30199 30189 -10
Branches 7271 7269 -2
==========================================
+ Hits 19008 19038 +30
+ Misses 11005 10966 -39
+ Partials 186 185 -1
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
looked at the mock fetch typescripting because both of the runs i saw related to #3624 mentioned HttpMap being the last test run that could have produced that error, but I think that is a fluke and it's probably dotplot.test.tsx or alignments.test.tsx above it or something like that that actually uses the DOM |
| @@ -33,7 +33,6 @@ module.exports = { | |||
| ], | |||
| setupFiles: [ | |||
| '<rootDir>/config/jest/textEncoder.js', | |||
| '<rootDir>/config/jest/createRange.js', | |||
There was a problem hiding this comment.
createRange polyfill no longer needed, and in fact, causes problems if used
* Connection type changes * Misc typescript fixes to fetch mocks
Ideally will help, it helped in the react 18 branch which may have surfaced the issues more readily but may be more rare on current react 17. Uses the 'user-event' library from testing-library, which has more natural 'integration testing' methods