Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse click-and-drag behavior in the alternative "cursor mode" for the dotplot view #3632

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Apr 7, 2023

The non-default mode to toggle click-and-drag to pan had a bug when you use the ctrl+click-and-drag where it wouldn't detect mouse up properly and would pan around even after you mouse up

This fixes that issue, and then also saves that setting to local storage

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 7, 2023
@cmdcolin cmdcolin force-pushed the improve_dotplot_mouse_pan_behavior branch from 28685e4 to c816104 Compare April 8, 2023 19:49
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 8, 2023
@cmdcolin cmdcolin merged commit dc4c108 into main Apr 8, 2023
@cmdcolin cmdcolin deleted the improve_dotplot_mouse_pan_behavior branch April 8, 2023 22:03
cmdcolin added a commit that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant