Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump x-data-grid dependency, refactors for BaseFeatureDetails, add GridToolbar #3660

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Apr 24, 2023

  • The refactors some code in BaseFeatureDetails, splits into smaller modules
  • Removes many uses of type any in BaseFeatureDetails, changes to unknown
  • Adds 'resize handles' to the columns of the data grid in BaseFeatureDetails (these data grids in the feature details are visible when loading some things like mygene.info feature details which have highly detailed feature info)
  • Removes the 'GridAutoSizer' re-export since that was removed upstream, so this PR removes it also [DataGrid] Replace GridAutoSizer with ResizeObserver mui/mui-x#8091
  • Adds a resizeobserver 'polyfill' since the new 'grid autosize' that they have requires it
  • Add GridToolbar to data grids, allowing e.g. CSV export
  • Misc refactors

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 24, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 24, 2023
@cmdcolin cmdcolin changed the title Bump x-data-grid dependency, refactors for BaseFeatureDetails Bump x-data-grid dependency, refactors for BaseFeatureDetails, add GridToolbar Apr 24, 2023
@cmdcolin cmdcolin force-pushed the bump_deps branch 3 times, most recently from f366d7f to 663e882 Compare April 24, 2023 17:16
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #3660 (f5a3201) into main (b492af9) will decrease coverage by 0.20%.
The diff coverage is 9.90%.

@@            Coverage Diff             @@
##             main    #3660      +/-   ##
==========================================
- Coverage   62.83%   62.64%   -0.20%     
==========================================
  Files         886      892       +6     
  Lines       30151    30236      +85     
  Branches     7281     7324      +43     
==========================================
- Hits        18946    18940       -6     
- Misses      11023    11113      +90     
- Partials      182      183       +1     
Impacted Files Coverage Δ
...BaseFeatureWidget/BaseFeatureDetail/ArrayValue.tsx 0.00% <0.00%> (ø)
...BaseFeatureWidget/BaseFeatureDetail/Attributes.tsx 0.00% <0.00%> (ø)
...BaseFeatureWidget/BaseFeatureDetail/BasicValue.tsx 0.00% <0.00%> (ø)
.../BaseFeatureWidget/BaseFeatureDetail/FieldName.tsx 0.00% <0.00%> (ø)
...re/BaseFeatureWidget/BaseFeatureDetail/UriLink.tsx 0.00% <0.00%> (ø)
...core/BaseFeatureWidget/BaseFeatureDetail/index.tsx 73.62% <ø> (ø)
...s/core/BaseFeatureWidget/BaseFeatureDetail/util.ts 0.00% <0.00%> (ø)
packages/core/ReExports/modules.tsx 11.22% <ø> (+0.05%) ⬆️
packages/core/ui/ResizeBar.tsx 71.42% <ø> (-8.58%) ⬇️
...lignmentsFeatureDetail/AlignmentsFeatureDetail.tsx 67.64% <ø> (ø)
... and 7 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…ture details, helps with information getting cramped at bottom of screen in some cases
@cmdcolin cmdcolin merged commit f776497 into main Apr 26, 2023
@cmdcolin cmdcolin deleted the bump_deps branch April 26, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant