Create packages/product-core containing shared code between the various products

[rbuels]

Work in progress DRY-ing up shared code among the products. Primarily the session models in this first phase.

[rbuels]

@cmdcolin the plan for this PR is to split up the sessionModelFactory files (which are more than 1000 lines each) into multiple files by area of functionality (assemblies, connections, etc), and to factor out the duplicated parts of them into packages/product-core.

Are you OK with that plan?

The motivation for this is that the huge files and code duplication are making the session models increasingly hard to work on.

[cmdcolin]

i'm fine with it if it seems like it works right. I have previously tried to do this but found it can be difficult to properly "carve" out portions of the state model but if it works that's great (my previous attempt stalled #3206)

[codecov]

Codecov Report

Merging #3661 (acec95e) into main (21e2cd0) will increase coverage by 0.95%.
The diff coverage is 51.89%.

@@            Coverage Diff             @@
##             main    #3661      +/-   ##
==========================================
+ Coverage   62.61%   63.57%   +0.95%     
==========================================
  Files         894      915      +21     
  Lines       30246    29912     -334     
  Branches     7322     7264      -58     
==========================================
+ Hits        18939    19016      +77     
+ Misses      11124    10713     -411     
  Partials      183      183              

Impacted Files	Coverage Δ
...kages/core/assemblyManager/assemblyConfigSchema.ts	90.00% <ø> (ø)
...eElementTypes/models/BaseConnectionModelFactory.ts	75.00% <ø> (ø)
...re/pluggableElementTypes/models/baseTrackConfig.ts	58.33% <ø> (ø)
packages/core/util/types/index.ts	70.96% <ø> (ø)
products/jbrowse-desktop/src/JBrowse.tsx	5.00% <0.00%> (ø)
products/jbrowse-desktop/src/StartScreen/util.tsx	0.00% <0.00%> (ø)
products/jbrowse-desktop/src/indexJobsModel.ts	1.31% <ø> (ø)
products/jbrowse-desktop/src/jbrowseConfig.ts	66.66% <ø> (ø)
...ircular-genome-view/src/createModel/createModel.ts	37.50% <ø> (ø)
...-genome-view/src/createModel/createSessionModel.ts	34.37% <0.00%> (+22.88%)	⬆️
... and 35 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rbuels]

this allows non-null assertions in test code

[rbuels]

The change to how the root model is instantiated was done to break a dependency cycle between the root, session, and jbrowse model types

[rbuels]

@cmdcolin This might be getting close to ready to merge, I think. I don't know what effect it has on the doc generation you worked on though

[cmdcolin]

awesome, i'll check do a quick review. not too worried about docs for now, itll probably break e.g. the rootmodel page into multiple pages with the mixins but thats fine with me

[cmdcolin]

i'd say let's get it merged :) we can iterate on main

[rbuels]

I'm fine with that, merge when ready

[cmdcolin]

one thing i noticed, is that "BaseSession" might be mixed in multiple times

this doesn't appear to cause any issue though

[cmdcolin]

woooo merged. great work :) thanks @rbuels