Only double-click zoom if not clicking on feature #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
bug
|
the double click to zoom was added #3544 |
|
sort of similar problem to #3638 where we 'want to only zoom if the clicks weren't triggering something else' |
|
Is there any way to get this to trigger zoom in when the mouse is over the "bar" of an offset label? e.g. if i click in red circle currently nothing happens, a user might expect it to zoom in .. this might be non trivial cus there is technically something there |
Codecov Report
@@ Coverage Diff @@
## main #3670 +/- ##
=======================================
Coverage 62.64% 62.64%
=======================================
Files 892 892
Lines 30238 30238
Branches 7324 7324
=======================================
Hits 18944 18944
Misses 11111 11111
Partials 183 183
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@carolinebridge-oicr pushed a change to allow that |
carolinebridge
approved these changes
Apr 29, 2023
This was referenced May 3, 2023
cmdcolin
added a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed along with @carolinebridge-oicr that double clicking a feature toggles a zoom in. This only zooms in if the featureIdUnderMouse is undefined. Only particular display types may use the 'featureIdUnderMouse' concept, but this does help double click on feature not performing a zoom in